fix: increase estimated gas by 20% #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarranzav
reviewed
Apr 11, 2024
pcarranzav
approved these changes
Apr 11, 2024
| // Increase the estimated gas by 20% | ||
| let increased_estimate = estimated_gas * U256::from(120) / U256::from(100); | ||
|
|
||
| tx.gas(increased_estimate).send().await?.await?; |
There was a problem hiding this comment.
I'd suggest handling errors from this more explicitly, unless it's done somewhere else?
There was a problem hiding this comment.
It's handled above when we do let estimated_gas_tx = tx.estimate_gas().await; since we're simulating the tx. If there's another error it will be propagated and handled in the main loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.