Fix max duration calculations with multiple 0 vus stages at end #2573
+73
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In b725f03 we fixed the calculation of the stages, unfortunately we didn't notice that the max duration for the test was wrongly calculated. This also tries to fix cases where graceful* will extend the test more then needed. Previously the code did not take into account that multiple 0 VUs stages can mean that the VUs are long ago stopped before gracefulStop (for example) needs to be taken into account.
mstoykov
commented
Jun 16, 2022
| @@ -244,7 +250,7 @@ func (vlvc RampingVUsConfig) getRawExecutionSteps(et *lib.ExecutionTuple, zeroEn | |||
| } | |||
|
|
|||
| if zeroEnd { | |||
| steps = append(steps, lib.ExecutionStep{TimeOffset: timeTillEnd, PlannedVUs: 0}) | |||
| addStep(timeTillEnd, 0) | |||
There was a problem hiding this comment.
Looking at this again ... maybe I should just check that plannedVUs and timeOffset are different and add it only then 🤔
On the other hand we care to have a zero end and addStep will check for that it just might not be at the timeTillEnd offset 🤔 .... or maybe even that isn't possible with the changes above
oleiade
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In b725f03 we fixed the calculation of the stages, unfortunately we
didn't notice that the max duration for the test was wrongly calculated.
This also tries to fix cases where graceful* will extend the test more
then needed. Previously the code did not take into account that multiple
0 VUs stages can mean that the VUs are long ago stopped before
gracefulStop (for example) needs to be taken into account.