Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Display downstream error messages. #1071

Closed
tttoad opened this issue Nov 28, 2024 · 5 comments
Closed

[Feature] Display downstream error messages. #1071

tttoad opened this issue Nov 28, 2024 · 5 comments

Comments

@tttoad
Copy link
Contributor

tttoad commented Nov 28, 2024

Discussed in #1065

Originally posted by tttoad November 26, 2024
When a downstream service has an error, it is expected to display an error message to the user.
This message might be "xx arg is invalid" and error message with trace_id.

@yesoreyeram
Copy link
Collaborator

Can you provide more details about the issue and how to reproduce? It is not clear what do you meant by downstream error. ( FYI. every API provide different error interfaces when sending error ). Also it is hard to display errors in dashboard when the plugin expects the results instead. (handling unique type of errors specific to different API is not ideal )

@tttoad
Copy link
Contributor Author

tttoad commented Nov 29, 2024

Can you provide more details about the issue and how to reproduce? It is not clear what do you meant by downstream error. ( FYI. every API provide different error interfaces when sending error ). Also it is hard to display errors in dashboard when the plugin expects the results instead. (handling unique type of errors specific to different API is not ideal )

Image

I hope there is a way to pass the error to the front-end page for display.

Here,we can try to parse the body and return the content using method 'errorsource.DownstreamError(err, false)' if the content is not empty.

@yesoreyeram
Copy link
Collaborator

let me try... :)

@tttoad
Copy link
Contributor Author

tttoad commented Dec 3, 2024

let me try... :)

Any good news ?

@yesoreyeram
Copy link
Collaborator

#1076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants