Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold] Add withName in attribute #18

Closed
wants to merge 1 commit into from
Closed

[Hold] Add withName in attribute #18

wants to merge 1 commit into from

Conversation

ying-jeanne
Copy link
Collaborator

this is to solve problem #13

@sdboyer
Copy link
Contributor

sdboyer commented Aug 24, 2021

Crap. Looking through this, i just realized that having this attribute means we also have to rewrite not just the name that's written out for the label having the withName attribute, but also any structure that references that label.

That gets into a tangle requiring us to think about the graph as a whole. It should be doable, but not exactly easy. Given that we don't have a burning use case for this just yet, we can probably put a hold on this and focus on other, more impactful changes.

@ying-jeanne ying-jeanne changed the title Add withName in attribute [Blocked] Add withName in attribute Sep 2, 2021
@ying-jeanne ying-jeanne changed the title [Blocked] Add withName in attribute [Hold] Add withName in attribute Sep 2, 2021
@ying-jeanne ying-jeanne marked this pull request as draft September 16, 2021 14:04
@sdboyer sdboyer closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add withName attribute to allow direct control over generated object names
2 participants