Fix: log more information about Chromium's run #46
+35
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
reviewed
Nov 4, 2024
|
Renovate is now fixed and alpine updated, so |
roobre
reviewed
Nov 4, 2024
crocochrome.go
Outdated
Comment on lines
334
to
335
| logger.LogAttrs(ctx, slog.LevelError, "chromium process finished", attrs...) | ||
| logger.Error("chromium output", "stdout", stdout.String(), "stderr", stderr.String()) |
There was a problem hiding this comment.
Should we merge these two log lines? They were originally separated out of lazyness rather than purpose, and now that we're dynamically creating the message we could as well incorporate stdout/stderr in there.
There was a problem hiding this comment.
Done.
I'm a little skeptical about this, because there's a limit to the length of lines that will be pushed to Loki (256 kB).
I expect that if there's an error that triggers this, the useful information will be at the end of the log, which might get truncated.
But let's give this a try...
|
#51 caused a conflict but should be pretty minor. |
mem
force-pushed
the
mem/log-more-information
branch
from
9c20d0e to
08ecfa3
Compare
Regardless of whether there was an error or not, log some information about the run (resources, exit code, etc). Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
force-pushed
the
mem/log-more-information
branch
from
08ecfa3 to
885916e
Compare
roobre
approved these changes
Nov 4, 2024
|
Looking great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regardless of whether there was an error or not, log some information about the run (resources, exit code, etc).