Kafka server spans shouldn't be producers and consumers #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
requested review from
mariomac,
marctc and
rafaelroquetto
as code owners
| @@ -211,6 +211,9 @@ compile-cache: | |||
| @echo "### Compiling Beyla K8s cache" | |||
| CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) go build -mod vendor -ldflags="-X '$(BUILDINFO_PKG).Version=$(RELEASE_VERSION)' -X '$(BUILDINFO_PKG).Revision=$(RELEASE_REVISION)'" -a -o bin/$(CACHE_CMD) $(CACHE_MAIN_GO_FILE) | |||
|
|
|||
| .PHONY: debug | |||
| debug: | |||
| CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) go build -mod vendor -gcflags "-N -l" -ldflags="-X '$(BUILDINFO_PKG).Version=$(RELEASE_VERSION)' -X '$(BUILDINFO_PKG).Revision=$(RELEASE_REVISION)'" -a -o bin/$(CMD) $(MAIN_GO_FILE) | |||
There was a problem hiding this comment.
what is the difference of a binary compiled with this target?
There was a problem hiding this comment.
It compiles with no optimizations and disabled inlining. It's useful if we want to debug Beyla itself.
rafaelroquetto
approved these changes
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1452 +/- ##
==========================================
+ Coverage 80.92% 81.02% +0.10%
==========================================
Files 149 149
Lines 15255 15255
==========================================
+ Hits 12345 12361 +16
+ Misses 2302 2289 -13
+ Partials 608 605 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were marking Kafka server spans the same as client spans, so if Kafka itself was monitored we might be getting confusing spans in Tempo. This PR changes the kafka server spans to be server, rather than client.
Relates to #1423