fix: update slack image upload to use new API #256
+501
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
moustafab
force-pushed
the
moustafab/fix-slack-image-upload
branch
3 times, most recently
from
be2db7f
to
2d1e4e6
Compare
The old `files.upload` API is deprecated and will be removed soon. It doesn't work for new slack workspaces created after May 2024. The new flow requires a 3 step process: 1. Call `files.getUploadURLExternal` to get the upload URL and file ID. 2. Upload the file to the URL using a PUT request. 3. Call `files.completeUploadExternal` to complete the upload and link it to the thread. Addresses #255, #235, and grafana/grafana#93398
moustafab
force-pushed
the
moustafab/fix-slack-image-upload
branch
from
2d1e4e6
to
0512488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
files.uploadAPI is deprecated and will be removed soon. It doesn't work for new slack workspaces created after May 2024.The new flow requires a 3 step process:
files.getUploadURLExternalto get the upload URL and file ID.files.completeUploadExternalto complete the upload and link it to the thread.Addresses #255, #235, and grafana/grafana#93398