Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include screenshot URL to Telegram message #123

Open
yuri-tceretian opened this issue Aug 31, 2023 · 4 comments · May be fixed by #240
Open

Include screenshot URL to Telegram message #123

yuri-tceretian opened this issue Aug 31, 2023 · 4 comments · May be fixed by #240
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yuri-tceretian
Copy link
Contributor

Currently, Telegram integration sends two messages when an alert has a screenshot attached to it.
However, Grafana screenshot service can upload screenshots to a remote host and provides URL to the image in the alert.

When Grafana is configured this way, we probably can let users control how screenshots are sent by Telegram integration: add URL to the first message or send it as the second message.
@yuri-tceretian yuri-tceretian added the enhancement New feature or request label Aug 31, 2023
@grobinson-grafana grobinson-grafana moved this to Backlog in Alerting Sep 4, 2023
@iBug
Copy link

iBug commented Jan 8, 2024

If the original reasoning was

(sendPhoto API) does not present long messages well.

Then is it an option to combine image and text into one message when the text is short, and only send them in separate messages when the text is long?

@Kot-o-pes
Copy link

+1, if it worked in 8.5 grafana why it regressed in 10?

@yuri-tceretian yuri-tceretian added the good first issue Good for newcomers label Jun 14, 2024
@yuri-tceretian
Copy link
Contributor Author

I think this would be a good first issue. If someone is willing to take it, I promise to give prompt reviews.

@nutmos nutmos linked a pull request Aug 31, 2024 that will close this issue
Open
@nutmos
Copy link
Contributor

nutmos commented Sep 8, 2024

I opened a new PR #240 for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Alerting
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include screenshot URL to Telegram message nutmos/alerting
4 participants
@nutmos @iBug @yuri-tceretian @Kot-o-pes