Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possiblilty to share particular event #678

Open
lazyest opened this issue Aug 15, 2024 · 11 comments
Open

Possiblilty to share particular event #678

lazyest opened this issue Aug 15, 2024 · 11 comments

Comments

@lazyest
Copy link

lazyest commented Aug 15, 2024

From my perspective its useful to send a link to some event to colleague and I don't see easy way of doing this now

It will be nice to have a direct link for every event and provide some button to copy it in every event. Maybe just near removing button?

Now its boring to describe or copy-paste text from page.

@lazyest lazyest added the a:feature New feature or request label Aug 15, 2024
@eternal-flame-AD
Copy link
Member

eternal-flame-AD commented Aug 15, 2024

I think we can have the backend accept an url signed by the client token and return the message(s) specified in the signature even if you don't have that token. Something like /message/external?id=123&client_id=3&sig=$(HMAC(token, join("&", sort(query)))) If we want we can add even more things like expiration time, etc.

@eternal-flame-AD
Copy link
Member

@jmattheis Are you interested in this? I can write the backend part

@jmattheis
Copy link
Member

I'm not sure I 100% understand this request. Is this some kind of permalink to a specific message. e.g. localhost:8080/#/messages/21?id=5 where 21 is the app id and 5 is the message id?

Does this even need a backend change?

@eternal-flame-AD
Copy link
Member

I think what they meant is an url they can share a message to other people (so not the same user)

@jmattheis
Copy link
Member

Hmm this seems along the lines of multi user support which gotify doesn't really do. I don't expect this to be a feature many users want, so I'd wait for some other users feedback.

@lazyest
Copy link
Author

lazyest commented Aug 16, 2024

from my point of view it will be enough to have it for one user only, we didn't manage how mulituser work so all using same user ;) but sharing particular event with direct link is a request

@eternal-flame-AD
Copy link
Member

eternal-flame-AD commented Aug 16, 2024

I could create a branch and write a solution for the current version but I'm not very interested in keeping it maintained if it is not merged into master. I want to respect mattheis' decision on whether to merge it. It should not be too hard to maintain yourself if you have basic skills in Go and TS, and since Gotify codebase is mostly stable now probably a simple git pull will do in most cases. Let me know if you want to do that.

@lazyest
Copy link
Author

lazyest commented Aug 16, 2024

maybe its not so useless feature and it will be applied for whole product? ;)

@eternal-flame-AD
Copy link
Member

I would implement it mainstream if this is my personal project but I would like to defer to the actual creator on his wishes here.

@lazyest
Copy link
Author

lazyest commented Aug 16, 2024

You're damn right :) From my point I'm just humble asking for some useful feature

@johndo100
Copy link

I'm looking for it now. I have some data on my server need to push to a group of people since I don't want they delete message, something read-only. I think it's useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants