-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: SVG icon #982
Comments
Hi @DanielRamosAcosta, |
Oh, thanks for the response @geromegrignon |
💭 IntroductionWe need a svg version of our logo. ✏️ Task
|
Would this perhaps be an opportunity as well to simplify the logo, removing the shadows? I think it would show better on lower resolutions. |
Do you need to convert the current logo from PNG to SVG . |
Hi @Vishal2002, exactly! |
Assign me this issue to work on |
sure, done. Thanks for your help. |
Where I have to add the SVG file Can you tell me? |
You can add it in the media folder, naming it realworld-logo.svg. |
Will this issue get counted in the hacktoberfest? |
Please add a label of hacktoberfest-accepted otherwise it won't be counted |
sure I really appreciate the help and will apply the label on it (I don't put it on the project directly to avoid some spam). |
I am unable to see the change on the dashboard of hacktoberfest. |
Hi @Vishal2002, the label must be applied on the Pull Request, but you didn't submit one yet to the project. |
I looked at the file in your fork (https://github.com/Vishal2002/realworld/blob/main/media/realworld-logo%20(2).svg), and that's an inverted image, so it doesn't fit the requirement. By using it, the logo would be transparent with a black background. |
It took me two years, but finally I did it haha, fixed in #1550 (cc @geromegrignon) |
Relevant Scope
Frontend specs
Description
I've see that in the media directory are several sizes of the Real World icon, but are there any SVG?
Describe the solution you'd like
A SVG icon version
Describe alternatives you've considered
🤷🏽♂️
The text was updated successfully, but these errors were encountered: