Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the fingerprint updater and .binproto for Grafana #548

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

W0ngL1
Copy link
Contributor

@W0ngL1 W0ngL1 commented Nov 4, 2024

Hi @tooryx,

This PR is about #392 .

The grafana team started to build docker images from 9 years ago, the first version which has a official docker is 2.1.3, but some versions are not available now. So the actual fingerprints covers 348 versions, from 2.1.3(9 years ago) to the latest 11.3.0(2024.10.23).

And I'll update .binproto file soon today.

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Nov 4, 2024

Hi @tooryx, I cannot upload grafana.binproto (about 182MB) because of the github policy. So I used git-lfs to track it, but it seems I cannot upload it to public fork, can you fix it or upload it?

This is the link of grafana.binproto.
https://drive.google.com/file/d/1BwKc_msEiKfF4NfxM1X1J78fjpAPQuWp/view?usp=sharing

This is returns of Github Desktop.

batch response: @W0ngL1 can not upload new objects to public fork W0ngL1/tsunami-security-scanner-plugins
error: failed to push some refs to 'https://github.com/W0ngL1/tsunami-security-scanner-plugins.git'

@tooryx
Copy link
Member

tooryx commented Nov 18, 2024

Hi @W0ngL1,

I will try to think about a solution. I will let you know.

~tooryx

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Nov 18, 2024

Hi @tooryx, copy that.

And I think you or your teammates can upload this file manually, the community developers have no need to get git-lfs privileges.

@tooryx
Copy link
Member

tooryx commented Nov 21, 2024

Hi @W0ngL1,

For now, please just remove the LFS attribute. When we review this change, I will regenerate the signatures internally and that should solve this issue.

~tooryx

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Nov 21, 2024

Hi @tooryx,

I've removed lfs attribute, please check it if you're free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants