Web application fingerprint for TeamCity #401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooryx
added
Contributor main
There was a problem hiding this comment.
Hello @quanyang.
Thank you for your contribution. I'm noticing that there are newer Teamcity's versions (https://www.jetbrains.com/teamcity/download/other.html). Please include also those into the version.txt file and commit the final file with all the hashes.
I'm also noticing that you are not removing the Teamcity's folder once the container is stopped. Please do so, this will reduce the disk space occupied.
Moreover there is a minor issue to address, you can find it down below.
Feel free to reach out
~ Leonardo (Doyensec)
| # Path to the configurations for starting a live instance of the service. | ||
| APP_PATH="${SCRIPT_PATH}/app" | ||
| # Path to the temporary data holder. | ||
| TMP_DATA="/root/teamcity_fingerprints" |
There was a problem hiding this comment.
Please change the folder to /tmp/teamcity_fingerprints
|
Hello @quanyang. Friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web application fingerprint for TeamCity.
Includes the update script, docker compose, file with list of versions up till 2021 and the fingerprint binproto for the versions.
@tooryx PTAL
#138