Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI PRP: Request Flyte Exposed UI & API #425

Open
maoning opened this issue Mar 18, 2024 · 18 comments · May be fixed by #528
Open

AI PRP: Request Flyte Exposed UI & API #425

maoning opened this issue Mar 18, 2024 · 18 comments · May be fixed by #528
Assignees
Labels
ai-bounty-prp Identify an AI bounty plugin Contributor main The main issue a contributor is working on (top of the contribution queue).

Comments

@maoning
Copy link
Collaborator

maoning commented Mar 18, 2024

Target platform:

Require further research to identify how an exposed Flyte dashboard can be compromised for RCE.

Please read the rules of engagement first at #409.

@maoning maoning added help wanted Extra attention is needed ai-bounty-prp Identify an AI bounty plugin labels Mar 18, 2024
@secureness
Copy link
Contributor

flyte has a feature that allows us to push custom Python scripts (without authentication). I can work on this, is this counted as a critical submission(max bounty)?

@maoning
Copy link
Collaborator Author

maoning commented Mar 20, 2024

Hi @secureness,

Yes, if this vulnerability is an RCE and universal to all flyte applications with insecure configurations (not related to specific business logic), then it is counted towards critical rating.

Please make sure the following items are completed before the plugin implementation:

@maoning maoning added PRP:Accepted and removed help wanted Extra attention is needed labels Mar 20, 2024
@secureness
Copy link
Contributor

Hi @maoning
after hours of working, I successes in setting up a vulnerable instance (which took a lot of time) but the main problem is that we can't write a plugin for the grpc protocol also another problem is we need to serve our exploit file that contains the payload by an HTTP server. I'll choose another plugin to continue working.

@maoning
Copy link
Collaborator Author

maoning commented Mar 25, 2024

Thank you @secureness for the investigation. Could you submit your vulnerable config to google/security-testbeds and document the exploit process here in more details so that if when we make exploit file hosting possible and add a grpc client to Tsunami, you or someone else can continue with the work?

@maoning
Copy link
Collaborator Author

maoning commented Mar 25, 2024

For payload hosting part, I wonder if we could just host it in Tsunami github repo. Let me take a look at grpc client options for Tsunami.

@secureness
Copy link
Contributor

@maoning it would be good if we could host the payload in the tsunami GitHub repo! because they accept an HTTP URL.
Also, today I found out that there is grpc-gateway and we can use HTTP requests with JSON body to send requests.

@secureness
Copy link
Contributor

@maoning is there any chance that we wrap the flyte cli in Java? because there are many many http requests and it can be installed simply with pip.

@maoning
Copy link
Collaborator Author

maoning commented Mar 27, 2024

@secureness Does grpc client route also require same number of requests? I think if everything is equal, adding a grpc client to Tsunami could be useful in the long run for other services using grpc protocol.

@secureness
Copy link
Contributor

these days I can see many big applications that use grpc-gateway besides their grpc server, I don't think it is a top priority to have a grpc client embedded in the tsunami security scanner plugin ecosystem.

Does grpc client route also require same number of requests?

yes, the grpc-gateway is the main grpc just wrapped with JSON and HTTP as far as I know.
there are nearly 6 sequential requests for creating a new project for the tsunami scanner, and we need around 6 requests to create and run a workflow which is really huge and time-consuming, I'm scared of implementing this plugin.

@maoning
Copy link
Collaborator Author

maoning commented Mar 28, 2024

As adding the cli client increases the complexity of Tsunami deployment, let's put this issue on hold and prioritize other requests for now.

@secureness
Copy link
Contributor

OK, I share the setup guide on the testbed repo.

@hayageek
Copy link
Contributor

@maoning,
I've worked with Flyte before and can handle this task. I have researched, It can be implemented without flyte CLI
Can I go ahead and start?

By the way, I've already completed this pull request: tsunami-security-scanner-plugins#488.

@tooryx
Copy link
Member

tooryx commented Jul 24, 2024

Hi @hayageek, we can discuss it once your queue is empty, thank you!

~tooryx

@tooryx
Copy link
Member

tooryx commented Jul 31, 2024

Hi @hayageek, sorry I missed that this was an AI PRP. You can work on this.

~tooryx

@tooryx tooryx assigned hayageek and unassigned secureness Jul 31, 2024
@tooryx tooryx added Contributor main The main issue a contributor is working on (top of the contribution queue). and removed PRP:Inactive labels Jul 31, 2024
@hayageek
Copy link
Contributor

hayageek commented Aug 2, 2024

Hi @tooryx , Shall I submit the form https://bughunters.google.com/report/tsunami and start work ?

@tooryx
Copy link
Member

tooryx commented Aug 5, 2024

Hi @hayageek,

Yes, thank you.

~tooryx

@hayageek
Copy link
Contributor

hayageek commented Aug 5, 2024

@tooryx , I have submitted the report (https://issuetracker.google.com/issues/357557468). I will start the work.

@hayageek
Copy link
Contributor

Hi @tooryx , I have created a PR for the issue. #528

@tooryx tooryx linked a pull request Oct 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai-bounty-prp Identify an AI bounty plugin Contributor main The main issue a contributor is working on (top of the contribution queue).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants