Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the development Compose set-up to allow restricted company contexts #3225

Open
jbaptperez opened this issue Nov 21, 2024 · 2 comments · May be fixed by #3226
Open

Adapt the development Compose set-up to allow restricted company contexts #3225

jbaptperez opened this issue Nov 21, 2024 · 2 comments · May be fixed by #3226
Assignees
Labels
Deployment Issue related to deployment

Comments

@jbaptperez
Copy link

Is your feature request related to a problem? Please describe.
The current Compose set-up for development is made for machines assumed to have an unrestricted access to the internet.

In several companies, accessing to internet (with different TLS certificates for TLS inspection) or remote repositories (Ubuntu/Debian PPAs, Node NPM or Python PyPI) is restricted and developers must use internal CA certificates or mirrors instead of official ones to get the necessary dependencies.
This happens in particular to build and even run (frontend) the Timesketch development image.

The actual Compose set-up does not allow the developer to adapt the image build process to his company restrictions, e.g. setting a different base image like a custom Ubuntu with company TLS certificates, setting their own internal mirror URLs or defining a specific configuration file for a package manager (npm or pip).

Describe the solution you'd like
Upgrade the development Compose set-up so that it allows a custom configuration using environment variables.

Custom environment variables should be defined in a .env file, read by Compose but not versioned in Git.
The default values should be obtained via a template file.
Custom values should be set in the .env file, and only in this file.

Describe alternatives you've considered
Modify the current Dockerfiles, Compose files, environment files, etc. to make them fit the company requirements, keeping them excluded from any Git versioning.
This would imply constant local file management, with the risk to include undesired files, by mistake, in commits related to contributions.
Moreover, every developers having company restrictions would maintain their own custom set-up.

Additional context
Such a feature would allow more contributors to join the project as they could contribute in a pure professional context.

Personally, I need such a feature in order to properly work on the issue #3219 in my company.

@jbaptperez jbaptperez linked a pull request Nov 21, 2024 that will close this issue
4 tasks
@jkppr
Copy link
Collaborator

jkppr commented Nov 22, 2024

Thanks for the suggested changes @jbaptperez . I'll have a look within the next week.

@jkppr jkppr added the Deployment Issue related to deployment label Nov 22, 2024
@jbaptperez
Copy link
Author

@jkppr, I pushed a PR #3226 that I regularly rebase for a review.

Can you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment Issue related to deployment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants