Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/repro: tolerate scp errors #5388

Open
a-nogikh opened this issue Oct 11, 2024 · 1 comment
Open

pkg/repro: tolerate scp errors #5388

a-nogikh opened this issue Oct 11, 2024 · 1 comment
Assignees
Labels

Comments

@a-nogikh
Copy link
Collaborator

We see numerous failures like this:

message : repro failed: failed to copy syz-execprog to VM: failed to run ["scp" "-P" "22" "-F" "/dev/null" "-o" "UserKnownHostsFile=/dev/null" "-o" "IdentitiesOnly=yes" "-o" "BatchMode=yes" "-o" "StrictHostKeyChecking=no" "-o" "ConnectTimeout=10" "-v" "/syzkaller/syzkaller/current/bin/linux_amd64/syz-execprog" "root@IP:./syz-execprog"]: exit status 255

It should okay to just retry the reproduction step several times rather than abort the whole process -- in the end, we're fuzzing instrumented developmental trees and there can be all sorts of sporadic problems.

@a-nogikh a-nogikh added the bug label Oct 11, 2024
@a-nogikh a-nogikh self-assigned this Oct 11, 2024
@a-nogikh
Copy link
Collaborator Author

const attempts = 3
for i := 0; i < attempts; i++ {
// It's hard to classify all kinds of errors into the one worth repeating
// and not. So let's just retry runs for all errors.
// If the problem is transient, it will likely go away.
// If the problem is permanent, it will just be the same.
result, err = callback()
if err == nil {
break
}
}

Ah, we actually already do it 3 times. So for some kernels scp fails 3 times in a row?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant