dashboard/app: report full git repo

[dvyukov]

> git tree:       upstream

It would be useful to know the precise git tree.

https://lore.kernel.org/all/[email protected]/

IIRC we had other requests related to saying "upstream", but not accepting "upstream" in patch testing requests.
Should we simply always provide full git repo address w/o abbreviation?

[novitoll]

We are using {{.KernelRepoAlias}} in go templates:

syzkaller/dashboard/app/templates/mail_bug.txt

Line 8 in 6f888b7

git tree: {{.KernelRepoAlias}}

Should we use something like git tree: ({{.KernelRepoAlias}}) {{.KernelRepo}}, e.g. git tree: (upstream) git://full-repo.git?

$ git describe --contains 493ffd6605b2
next-20221011~172

We can also add additional field like KernelRepoTag in dashapi.BugReport to show the tag containing KernelCommit

Same template change for:

• dashboard/app/templates/mail_bisect_result.txt
• dashboard/app/templates/mail_fix_candidate.txt
• dashboard/app/templates/mail_test_result.txt

[a-nogikh]

IIRC we had other requests related to saying "upstream", but not accepting "upstream" in patch testing requests.

We do support "upstream" in patch testing already for quite a while now.

We can also add additional field like KernelRepoTag in dashapi.BugReport to show the tag containing KernelCommit

I'd assume people care more about the kernel tree specifically -- we already report the kernel commit that we fuzzed, so together with the tree that should be hopefully enough information (?)

Editing the mail_*.txt templates is unfortunately quite annoying because of tons of affected tests that also have to be updated after each template change, so we'd better indeed first agree how it should look like.

[novitoll]

I'd assume people care more about the kernel tree specifically -- we already report the kernel commit that we fuzzed, so together with the tree that should be hopefully enough information (?)

AFAIU, the user intention was in showing the current git tag where kernel commit belongs to.

On Thu, 13 Oct 2022 at 15:53, Andrew Price [email protected] wrote:

On 13/10/2022 14:31, syzbot wrote:

Hello,

syzbot found the following issue on:

HEAD commit: 493ffd6605b2 Merge tag 'ucount-rlimits-cleanups-for-v5.19'..

$ git describe --contains 493ffd6605b2
next-20221011~172

git tree: upstream

It would be useful to know the precise git tree.

Currently, on my v6.11-rc7 git tree, the same commit shows

$ git describe --contains 493ffd6605b2d3d4dc7008ab927dba319f36671f
v6.1-rc1~99

If that's what I understand, then I guess, we can either change the rvalue of KernelRepoAlias, so we won't have to change related tests, e.g. show the tag instead of upstream, but the tree notion here "upstream" is crucial, that's why the following
git tree: ({{.KernelRepoAlias}}) {{.KernelRepoTag}} might be sufficient and I'll take care of affected tests in syzkaller repo (not sure on what I'm signing up for). What do you think?