Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collectModuleName breaks in the presence of MagicHash #80

Open
isovector opened this issue Apr 15, 2021 · 1 comment
Open

collectModuleName breaks in the presence of MagicHash #80

isovector opened this issue Apr 15, 2021 · 1 comment

Comments

@isovector
Copy link
Contributor

Consider the perfectly reasonable name under -XMagicHash: Jn#. This causes an error:

Unable to parse RdrNameStr: "Jn#"
CallStack (from HasCallStack):
  error, called at src/GHC/SourceGen/Name/Internal.hs:106:10 in ghc-source-gen-0.4.0.0-5bO8D09FGq6LIxEy1df7VD:GHC.SourceGen.Name.Internal
@judah
Copy link
Collaborator

judah commented Apr 18, 2021

Thanks for the report. This should be an straightforward fix for the IsString instance in GHC.SourceGen.Name.Internal. Would you like to send a patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@judah @isovector