-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow library alpha02 crashes when PlanDefinition has an .action.condition? #1733
Comments
In case it helps, the actual intent of the condition expression was to check |
Bryn's suggestion: try use can you plz try william? |
This is the result of using
|
This is a bug in FhirPath evaluations with a null base in the FHIR Core: PR: hapifhir/org.hl7.fhir.core#1015 We will need to wait for the solution to trickle down into HAPI, then the cql-evaluator, then workflow. |
It looks like Vitor's fix was reverted: hapifhir/org.hl7.fhir.core#1017 I'm not sure why, I don't see any discussion on github other than it was reverted by request of Grahame Grieve. This bug does significantly hamper care plan generation, as encoding the conditional logic in FHIR is a primary value. I'm not sure what the timeline is for the fix to trickle down to the workflow library, is there a workaround besides implementing it in application logic? |
They are debating if that is the way it should be or not. The bug should only happen in FhirPath expressions. CQL expressions should work. |
It seems to also happen with CQL expressions though: please see crash in #1733 (comment) |
Different error, though. I didn't get there yet. |
The CQL/expression error is fixed on the CQL Evaluator 2.3. I am making a PR to upgrade the workflow |
From Vitor re: CQL There is a bug in the version of the Jackson processor that HAPI is using hapifhir/hapi-fhir#4308 That bug only happens when using graddle. The evaluator was migrated to the new buggy version and now we need to wait for hapi to upgrade first, update the evaluator and only then update the workflow. |
Describe the bug
I am able to generate a care plan using a minimal Plan Definition. When I add a
condition
to the plan definition, the app crashes instead withComponent
Workflow Library
To Reproduce
See https://github.com/williamito/fhir-engine-test/blob/main/app/src/main/java/com/example/enginetest/MainActivity.kt
It works with
And crashes with
I also tried variations of
"language": "text/cql"
and got a similar crash from the CQL libraries complaining about a missing resource.Expected behavior
Trivial
condition
evaluates to true and care plan is generated.The text was updated successfully, but these errors were encountered: