Additional lesson preview accessibility #2828
Open
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -109,7 +109,7 @@ | |||
| */ | |||
| get_tooltip: function( msg ) { | |||
| var $el = $( '<div class="llms-tooltip" />' ); | |||
| $el.append( '<div class="llms-tooltip-content">' + msg + '</div>' ); | |||
| $el.append( '<div class="llms-tooltip-content" aria-hidden="true">' + msg + '</div>' ); | |||
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 4 days ago
To fix the problem, we need to ensure that the msg variable is properly escaped before being inserted into the HTML. This can be achieved by using a function that escapes HTML special characters, thereby preventing any potential XSS attacks.
The best way to fix this without changing existing functionality is to create a utility function that escapes HTML special characters and use this function to sanitize the msg variable before it is used in the HTML construction.
Suggested changeset
1
assets/js/app/llms-lesson-preview.js
| @@ -111,5 +111,20 @@ | ||
| var $el = $( '<div class="llms-tooltip" />' ); | ||
| $el.append( '<div class="llms-tooltip-content" aria-hidden="true">' + msg + '</div>' ); | ||
| $el.append( '<div class="llms-tooltip-content" aria-hidden="true">' + this.escapeHtml(msg) + '</div>' ); | ||
| return $el; | ||
| }, | ||
|
|
||
| /** | ||
| * Escape HTML special characters in a string | ||
| * | ||
| * @param string str string to escape | ||
| * @return string | ||
| * @since 3.16.12 | ||
| */ | ||
| escapeHtml: function( str ) { | ||
| return str.replace(/&/g, '&') | ||
| .replace(/</g, '<') | ||
| .replace(/>/g, '>') | ||
| .replace(/"/g, '"') | ||
| .replace(/'/g, '''); | ||
| }, | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tooltip text as a screen-reader only element and indicates the link is disabled when a lesson cannot be accessed.
Fixes #2827
How has this been tested?
Manually
Screenshots
CleanShot.2024-12-09.at.10.08.31.mp4
Checklist: