Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Git URLs that don't end in .git #30

Open
philpax opened this issue Sep 3, 2022 · 1 comment
Open

Accept Git URLs that don't end in .git #30

philpax opened this issue Sep 3, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@philpax
Copy link
Contributor

philpax commented Sep 3, 2022

The DIP17 spec allows for anything that can be git cloned; GitHub will serve up the repo to a Git client even if you don't end in .git. I think we can remove the check and it should Just Work:tm:

@philpax philpax added the bug Something isn't working label Sep 3, 2022
@wolfcomp
Copy link
Contributor

Be warned that this would also need to modify the code added with #26 as it expects the URL to have .git currently with [..^4] on the AbsolutePath of the URL that is sent.

Note: Internally in C# this is called URI as it can be anything that follows <method>://<path>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants