Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The check for Dalamud-provided DLLs is flawed #27

Open
anna-is-cute opened this issue Aug 31, 2022 · 0 comments
Open

The check for Dalamud-provided DLLs is flawed #27

anna-is-cute opened this issue Aug 31, 2022 · 0 comments

Comments

@anna-is-cute
Copy link

Plogon rejects builds that have outputs containg DLLs that Dalamud provides. The way it does this is flawed. This check should be reworked or removed.

Example:
Tourist depends on FFXIVWeather.Lumina (or something similar to that, cba to look up the name). That dependency depends on Lumina from NuGet. This means that Lumina.dll ends up in Tourist's output. However, Tourist's DalamudPackager is configured to exclude that DLL, and the actual output zip doesn't contain it. Plogon blocks this setup from being merged.

There is really very little I can do about this, short of adding a build step to delete DLLs from my output to satisfy an overzealous CI lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant