Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-internalize crypto module #164

Open
utdrmac opened this issue Sep 28, 2020 · 2 comments
Open

De-internalize crypto module #164

utdrmac opened this issue Sep 28, 2020 · 2 comments

Comments

@utdrmac
Copy link
Contributor

utdrmac commented Sep 28, 2020

Many of the crypto functions, like b58cdecode, can be utilized by other go-based applications doing Tezos stuff. By putting these functions in their own /crypto module, and marking all functions as exportable, go-tezos can continue using them, plus other applications too vs re-inventing/copying code.

@utdrmac
Copy link
Contributor Author

utdrmac commented Sep 28, 2020

$ go build
package mytesting
	nonce.go:7:2: use of internal package github.com/goat-systems/go-tezos/v3/internal/crypto not allowed

According to godocs:

An import of a path containing the element “internal” is disallowed if the importing code is outside the tree rooted at the parent of the “internal” directory.

Please consider moving the crypto code into a differently named directory so that it can be used by other projects.

@utdrmac utdrmac changed the title Create crypto module for export De-internalize crypto module Oct 9, 2020
@DefinitelyNotAGoat
Copy link
Collaborator

I can do this. I will review the package before making it public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants