Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when replying to code comment from "Conversation" tab #32684

Closed
jpraet opened this issue Nov 30, 2024 · 3 comments · Fixed by #32685
Closed

Error when replying to code comment from "Conversation" tab #32684

jpraet opened this issue Nov 30, 2024 · 3 comments · Fixed by #32685
Labels

Comments

@jpraet
Copy link
Member

jpraet commented Nov 30, 2024

Description

Replying to a code comment from "Conversation" tab gives an error on https://demo.gitea.com.
When replying to the same comment from the "Files Changed" tab, it works fine.

JS error:

Error: TypeError: e.closest(...) is null
    C0 repo-diff.ts:58
    Be dom.ts:361
repo-diff.ts:90:14
    C0 repo-diff.ts:90
    Be dom.ts:361

Gitea Version

1.23.0+dev-727-ga1f56f83bf

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

https://demo.gitea.com/jpraet/test/pulls/1

Database

None

@jpraet
Copy link
Member Author

jpraet commented Nov 30, 2024

Could be a regression from #32596.

@wxiaoguang
Copy link
Contributor

Will fix it

@wxiaoguang
Copy link
Contributor

Fix JS error when reply commenton Conversation page #32685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants