Emails of new comments should use [email.incoming] REPLY_TO_ADDRESS, not [mailer] FROM

[bilogic]

Description

1. Issue emails are shown as being sent by [mailer] FROM= of the app.ini
2. This results in chaos when some reply to it instead of the plus address from [email.incoming] REPLY_TO_ADDRESS
3. I can't test on demo.gitea.com as I can't register an account
4. As I understand it, it is safe to set the FROM and REPLY_TO of the email content as the plus address
5. Providers like GMail will overwrite it and self hosted SMTPs will allow it when configured correctly

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

self hosted using docker

Database

None

[hiifong]

Regarding the fourth question, not all emails provider are support plus addressing.

[hiifong]

I can't reproduce this problem locally.

[bilogic]

Hi, thanks for getting back

1. This is the main problem: I don't want any users to know about git@ to prevent them from replying to it
2. I would like to force them to only reply to noreply+.....@
3. As I understand it, self-hosted SMTP can be configured to allow sending as anyone, so Gitea can set from: noreply+.....@, this is the main change I'm asking for
4. For public providers like Google, if Gitea set from: [email protected], Google will force it back to from: [email protected], so it will be as per normal for them

What do you think?

[hiifong]

I understand what you mean. I think we can replace From with git+{any string}@xxxx.xxx when sending emails using smtp.

[bilogic]

I understand what you mean. I think we can replace From with git+{any string}@xxxx.xxx when sending emails using smtp.

It has to match whatever reply-to: was configured to in [email.incoming] REPLY_TO_ADDRESS and should apply to only emails arising from issue comments