fix(#32667): 🐛 Fixe a keystring misuse and refactor duplicates keystrings #32668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SimonPistache
commented
Nov 28, 2024
•
SimonPistache
commented
- Fixes a translation keystring misuse where the string 'open milestones' is used in place of 'closed milestones'.
- De-duplicates the use of 'open milesones' and 'closed milestones' keystrings on the sidebar of an issue, reusing the ones on the issues filter and action bars.
- Closes Reuse the same translation keystrings for the same labels in milestone dropdown menus #32667
…s keystrings - Fixe a translation keystring misuse where the string 'open milestones' is used in place of 'closed milestones'. - De-duplicates the use of 'open milesones' and 'closed milestones' keystrings on the sidebar of an issue, reusing the ones on the issues filter and action bars.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
Could the unused keys like "issues.new.closed_milestone" and "issues.new.open_milestone" be deleted from locale_en-US.ini ? (only en-US is enough, other files will be managed automatically) |
wxiaoguang
approved these changes
Nov 29, 2024
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Nov 29, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wxiaoguang
removed
the
reviewed/wait-merge
Wait for this for a while, in case there would be new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.