-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actions] Support concurrency syntax #24769
Comments
Edited to also include an advanced example, it's from our current github actions workflows and serves the purpose of cancelling duplicate runs for the same PR. |
Being able to cancel in-progress builds when a new build comes in would be super helpful for my project! Would love to see this implemented ❤️ Thanks for all your hard work team! |
For push events, the auto-cancellation already works on 1.21, you just don't have control over it AFAIK |
Oh that's very interesting, I believe this is the related PR for reference: #25716 Thanks for calling this out @denyskon, you have the best tips! My understanding is this works off Edit: I tested with |
@wolfogre can I request a way to disable the default auto-cancellation (#25716 (comment)) I have a git repo with multiple ansible playbooks and my CI workflow only deploys whichever one was modified in the commit it's running on. I use renovate to merge a lot of updates and it'll just cancel the deployments midway through. It doesn't even trigger the fail notification step I have as the job is completely gone. |
@calvinbui Sorry I don't have plans to implement the suggestion I left at #25716 (comment) , maybe others can help. However, I don't thinks auto-cancellation is a bad idea in your case. What if #522 finisehed first, and then #521 continued deploying (somethink slowed it down) with an older version? |
Can you clarify if you mean Gitea won't implement this or you won't be working on it?
In my case, that would be fine. one is updating a tool called notify_push and the other is updating another tool called outline. They are separate files which I am handling. But yes, I understand the conundrem you're explaining. |
Sorry for the confusion. I meant to say that I don't have any plans to do it because I'm busy with other things (I thought you were asking me when you mentioned me). I cannot represent Gitea or the Gitea maintainers team. That's why I said "maybe others can help". |
I'm still struggling with autocancellation. |
I created a new issue for opt-out from auto-cancelling: #32662 This should be fixed separately from concurrency feature. |
Feature Description
simple:
advanced:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
The text was updated successfully, but these errors were encountered: