Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.0 #108

Closed
wants to merge 8 commits into from
Closed

V1.0 #108

wants to merge 8 commits into from

Conversation

alteous
Copy link
Member

@alteous alteous commented Sep 22, 2017

Closes #13 and #12

bwasty
bwasty approved these changes Sep 22, 2017
View reviewed changes
Copy link
Member

@bwasty bwasty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh - time for 1.0 already? :)

Did a quick "all-samples-test" - found no new issues.

(...still haven't fixed the Data URI handling, so many embedded models still fail. That's also my only nitpick at the moment - I'd wish the library would make image loading a bit simpler or at least provide a complete example).

@alteous
Copy link
Member Author

alteous commented Sep 22, 2017

Ooh - time for 1.0 already?

I think so. I've made this PR mainly for visibility. I don't expect this to be merged within the next week.

@alteous
Copy link
Member Author

alteous commented Sep 22, 2017

I'd wish the library would make image loading a bit simpler or at least provide a complete example).

How could we address this? Would a read_image function in gltf-utils plus gltf-importer returning (Gltf, Buffers, Images) be suitable?

@bwasty
Copy link
Member

bwasty commented Sep 22, 2017

I'd wish the library would make image loading a bit simpler or at least provide a complete example).

How could we address this? Would a read_image function in gltf-utils plus gltf-importer returning (Gltf, Buffers, Images) be suitable?

I've also thought about gltf-utils, not sure if it has to be in gltf-importer as well. Essentially it should encapsulate this block minus the image decoding - give it a gltf::image::Image, get raw binary data without caring whether it comes from a file, GLB or Data URI. Not sure in how far a really simple interface is feasible. It doesn't have to be super convenient, but saving most of those lines would be nice.

alteous
alteous commented Sep 22, 2017
View reviewed changes
src/buffer.rs
@@ -13,6 +13,15 @@ use Gltf;

pub use json::buffer::Target;

/// The data referenced by a `Buffer`.
pub enum Data<'a> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #106

@alteous
Copy link
Member Author

alteous commented Oct 31, 2017

This is a long way off.

@alteous alteous closed this Oct 31, 2017
@alteous alteous deleted the v1.0 branch April 25, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwasty bwasty bwasty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alteous @bwasty