Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launchpad Search: search only when nothing is found #3763

Open
sergeibbb opened this issue Nov 15, 2024 · 0 comments · May be fixed by #3770
Open

Launchpad Search: search only when nothing is found #3763

sergeibbb opened this issue Nov 15, 2024 · 0 comments · May be fixed by #3770
Assignees
@sergeibbb
Milestone
Shortlist

Comments

@sergeibbb
Copy link
Member

sergeibbb commented Nov 15, 2024 •
edited
Loading

This issue is a follow-up of #3543

The problem

  • Users starts searching in the Launchpad
  • Some items that are presented become visible immediately
  • But after a second or two API search finishes and its result appear so the initial items stops being visible.

That's because we cannot control order of items in the quickpick when it's in the search/filtering state.

The solution

Search only when nothing is found locally.
@sergeibbb sergeibbb self-assigned this Nov 15, 2024
sergeibbb pushed a commit that referenced this issue Nov 18, 2024
@chivorotkiv
Searches only when nothing is found
d30067e 
(#3763)
@sergeibbb sergeibbb linked a pull request Nov 18, 2024 that will close this issue
Open
7 tasks
sergeibbb pushed a commit that referenced this issue Nov 18, 2024
@chivorotkiv
Searches only when nothing is found
ba24f42 
(#3763, #3770)
@sergeibbb sergeibbb added this to the Shortlist milestone Nov 18, 2024
@sergeibbb sergeibbb linked a pull request Nov 18, 2024 that will close this issue
Launchpad Search: Searches only when nothing is found #3770
Open
7 tasks
sergeibbb pushed a commit that referenced this issue Nov 19, 2024
@chivorotkiv @sergeibbb
Searches only when nothing is found
bc466d0 
(#3763, #3770)
@sergeibbb sergeibbb mentioned this issue Nov 24, 2024
Closed
sergeibbb pushed a commit that referenced this issue Nov 25, 2024
@chivorotkiv @sergeibbb
Searches only when nothing is found
529e536 
(#3763, #3770)
sergeibbb pushed a commit that referenced this issue Nov 25, 2024
@chivorotkiv @sergeibbb
Searches only when nothing is found
162f26a 
(#3763, #3770)
sergeibbb added a commit that referenced this issue Nov 25, 2024
@sergeibbb
Improves delayed detection of active items: uses onDidChangeActive
9b17351 
instead of a timout delay
(#3763, #3770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeibbb sergeibbb

Labels
None yet
Projects
None yet
Milestone
Shortlist
Development

Successfully merging a pull request may close this issue.

Launchpad Search: Searches only when nothing is found gitkraken/vscode-gitlens
1 participant
@sergeibbb