Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong description of the Settings / Security / Code security feature #35325

Closed
1 task done
akordowski opened this issue Nov 18, 2024 · 5 comments
Closed
1 task done

Wrong description of the Settings / Security / Code security feature #35325

akordowski opened this issue Nov 18, 2024 · 5 comments
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team

Comments

@akordowski
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

Multiple articles.

What part(s) of the article would you like to see updated?

Regarding the issue #35324 I noticed that in the GitHub docs the Settings / Security / Code security feature is refered as "Code security and analysis". This term occurs 32 times over 19 files in the docs. This should be updated to the correct name "Code security".

Additional information

I could provide a PR to fix this issues.
@akordowski akordowski added the content This issue or pull request belongs to the Docs Content team label Nov 18, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 18, 2024
@akordowski akordowski changed the title Wrong description of the **Settings / Security / Code security** feature Wrong description of the Settings / Security / Code security feature Nov 18, 2024
@akordowski akordowski mentioned this issue Nov 18, 2024
Closed
2 tasks
@nguyenalex836 nguyenalex836 added code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels Nov 18, 2024
@nguyenalex836
Copy link
Contributor

@akordowski Thank you for opening this issue and linking your PR! ✨ Once we've received a response from the team regarding the related issue - #35324, we'll review this issue and PR as well 💛

@subatoi
Copy link
Contributor

subatoi commented Nov 19, 2024 •
edited
Loading

@akordowski 👋 Many apologies, but the comment I made here applies here too

I'll discuss this internally as soon as I can, but because of the complications around versioning involved, I'm not sure if we'll be able to accept your PR.

However, I'd be happy to add you as a co-committer on any PRs we do raise. I'll leave this open for now, and we'll get back to you as soon as we can.

@akordowski
Copy link
Contributor Author

@subatoi I will resolve the conflicts at the #35327 PR. Please feel free to use it as a base to made any changes as required.

@subatoi
Copy link
Contributor

subatoi commented Nov 19, 2024

Thank you! I really appreciate that—depending on the outcome of our discussions we may well do that, or else at a minimum I'll make sure you're added as a co-committer on any new PRs.

@akordowski
Copy link
Contributor Author

@subatoi @nguyenalex836 As the PR is closed I close this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Code security feature descriptions akordowski/github-docs
3 participants
@akordowski @subatoi @nguyenalex836