C++: Actually check function names in MaD #18114
Merged
+25
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes quite an embarrassing bug: We forgot to check the function name when matching MaD models with
Function
s when dealing with non-member functions 😱That's ... quite bad. Luckily, there are several reasons for why this went unnoticed for 4 months:
boost::asio::buffer
andstd::format
Commit-by-commit review recommended. The last commit is just a cleanup of the conjuncts.