Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[view] Summary.util.ts 파일 리팩토링 #723

Open
pithesun opened this issue Sep 14, 2024 · 0 comments
Open

[view] Summary.util.ts 파일 리팩토링 #723

pithesun opened this issue Sep 14, 2024 · 0 comments
Assignees
@pithesun
Labels
✨ view
Milestone
v0.7.3

Comments

@pithesun
Copy link
Contributor

이슈내용

Summary.util.ts에서 return하지 않는 map 사용, 객체에 직접접근하여 값을 바꾸는 부분이 여러번 반복되어 가독성이 좋지 않은 부분이 있어
리팩토링을 진행하고자 합니다.

image
image
@pithesun pithesun mentioned this issue Sep 14, 2024
Merged
@pithesun pithesun assigned pithesun and rakseong and unassigned pithesun and rakseong Sep 14, 2024
@Sang-minKIM Sang-minKIM added this to the v0.7.3 milestone Sep 27, 2024
pithesun added a commit to pithesun/githru-vscode-ext that referenced this issue Sep 29, 2024
@pithesun
feature(view) : 클러스터 커밋 작성자 이름 중복 체크 테스트 작성(githru#723)
4e85da4
pithesun added a commit to pithesun/githru-vscode-ext that referenced this issue Sep 29, 2024
@pithesun
feature(view) : SummaryUtil 리팩토링(githru#723)
73e8058
@pithesun pithesun mentioned this issue Oct 6, 2024
Merged
pithesun added a commit to pithesun/githru-vscode-ext that referenced this issue Oct 20, 2024
@pithesun
refactor(view): 클러스터 커밋 작성자 이름 중복 체크 테스트 작성 수정(githru#723)
9dc298c
ytaek added a commit that referenced this issue Nov 20, 2024
@ytaek
Merge pull request #756 from pithesun/feature/723
77434a7 
 [Refactor] SummaryUtil 리팩토링(#723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pithesun pithesun

Labels
✨ view
Projects
None yet
Milestone
v0.7.3
Development

No branches or pull requests
3 participants
@pithesun @Sang-minKIM @rakseong