-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial derivative builtins #2277
Conversation
Clippy is freaking out for me locally, so I'm just force pushing now that I've appeased the CI running
Which even the CI suggested, however it then complained after I made the switch, and then didn't complain when I reverted it. 😵💫 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Overall it looks good!
One nit: Please try to to avoid using _
for match arms especially when that coincides with one remaining enum variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misclicked
Sounds good, does this also apply to resting the pattern if there's only one remaining field |
I think that's fine and depends on context; sometimes it might be worth explicitly ignoring members, sometimes we might not care at all and use the rest operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A rebase should take care of the linting issues; since we landed #2279.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thank you for the improvements!
* Add partial derivative builtins * [dot] emit derivative control * Fix fmt --------- Co-authored-by: Teodor Tanasoaia <[email protected]>
Adds the following from gfx-rs/wgpu#4402
Feel free to make any changes btw.