Launcher is incompatible with PyQt 5.10+ because of ".icon" on MyButton

[BigRoy]

Issue

The issue was reported here by Gitter user anilreddyg2. The error message was:

C:\>avalon
Using Python @ 'C:\Users\Anil\AppData\Local\Programs\Python\Python36-32\python.e
xe'
Using PyQt5 @ 'C:\Users\Anil\AppData\Local\Programs\Python\Python36-32\lib\site-
packages\PyQt5'
Using core @ 'C:\avalon-setup\git\avalon-core'
Using launcher @ 'C:\avalon-setup\git\avalon-launcher'
Using root @ 'C:\avalon-setup\git\avalon-examples\projects'
Using config: 'polly'
Starting avalon-launcher
QQmlApplicationEngine failed to load component
file:///C:/avalon-setup/git/avalon-launcher/launcher/res/qml/main.qml:79 Type My
Button unavailable
file:///C:/avalon-setup/git/avalon-launcher/launcher/res/qml/MyButton.qml:8 Cann
ot override FINAL property

Could not load QML file..

This seems related to an icon variable being added to Qt5.10.

Proposal

We should fix this so we are forward compatible with these versions. We could likely rename our "icon" property so it doesn't conflict with the new one implemented on AbstractButton.

Workaround

The current workaround would be to downgrade to lower than version PyQt 5.10.

[tokejepsen]

I cant seem to replicate this.

Could have anything to do with that is seems like its a 32-bit version of Python3 being used?

[thirstydevil]

Hi Guys
Just tried avalon default install guide. Installed Python 3.7.2 x64 and pip installed PyQt.
Got the following.

Looks like this issue is some properties are being marked as FINAL in QtQuick. (Not a QML expert)

C:\avalon>avalon
Using Python @ 'C:\Program Files\Python37\python.exe'
Using PyQt5 @ 'C:\Program Files\Python37\Lib\site-packages'
Using core @ 'c:\avalon\avalon-setup\git\avalon-core'
Using launcher @ 'c:\avalon\avalon-setup\git\avalon-launcher'
Using root @ 'c:\avalon\avalon-setup\git\avalon-examples\projects'
Using config: 'polly'
Starting avalon-launcher
QQmlApplicationEngine failed to load component
file:///c:/avalon/avalon-setup/git/avalon-launcher/launcher/res/qml/main.qml:79 Type MyButton unavailable
file:///c:/avalon/avalon-setup/git/avalon-launcher/launcher/res/qml/MyButton.qml:8 Expected token `identifier'

Could not load QML file..

C:\avalon>python --version
Python 3.7.2

C:\avalon>python
Python 3.7.2 (tags/v3.7.2:9a3ffc0492, Dec 23 2018, 23:09:28) [MSC v.1916 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

[thirstydevil]

Downgrading to PyQt5.09 resolved the issue.