Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model SANN #103

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Add model SANN #103

wants to merge 42 commits into from

Conversation

martin-carrasco
Copy link
Collaborator

Checklist

  • My pull request has a clear and explanatory title.
  • My pull request passes the Linting test.
  • I added appropriate unit tests and I made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My code is properly documented, using numpy docs conventions, and I made sure the documentation renders properly.
  • I linked to issues and PRs that are relevant to this PR.

Description

This PR adds the SANN [1] model to TBX. It consists of a model that, given predefined computations of neighbourhoods, is probably as expressive as a Simplicial Message Passing Network. It consists mainly of an MLP and aggregations based on Simplicial complexes.

Issue

This is important since it adds a fast and expressive way to test different embedding functions without incurring in costly message passing among simplifies.

Additional context

Refer to Gurugubelli, S., & Chepuri, S. P. (2024). SaNN: Simple Yet Powerful Simplicial-aware Neural Networks. In The Twelfth International Conference on Learning Representations. for more information.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 18.83117% with 125 lines in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (9939f39) to head (8af8846).

Files with missing lines Patch % Lines
...rms/data_manipulations/precompute_khop_features.py 9.09% 60 Missing ⚠️
topobenchmarkx/nn/readouts/sann.py 27.27% 24 Missing ⚠️
...enchmarkx/transforms/feature_liftings/duplicate.py 26.92% 19 Missing ⚠️
...obenchmarkx/nn/wrappers/simplicial/sann_wrapper.py 25.00% 15 Missing ⚠️
topobenchmarkx/evaluator/evaluator.py 0.00% 5 Missing ⚠️
topobenchmarkx/loss/loss.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   85.34%   82.17%   -3.18%     
==========================================
  Files         108      112       +4     
  Lines        3044     3197     +153     
==========================================
+ Hits         2598     2627      +29     
- Misses        446      570     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbg141 gbg141 closed this Nov 9, 2024
@martin-carrasco martin-carrasco self-assigned this Nov 9, 2024
@gbg141 gbg141 reopened this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants