Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merging of instruments to build a CfpInfo #1497

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

cquiroz
Copy link
Contributor

@cquiroz cquiroz commented Dec 2, 2024

odb is producing CfPs with a single instrument, we need to merrge all the rows (each with one instruments) grouped by cfp id

@mergify mergify bot added the service label Dec 2, 2024
Copy link
Contributor

@swalker2m swalker2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right to me. 👍

case None => cfp.addInstrument(oinst).some
case Some(c) => c.addInstrument(oinst).some
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .fold could come on the CompileOps result of compile and eliminate the .last.map(_.getOrElse(Map.empty)) bit at the end.

@cquiroz cquiroz merged commit a82b721 into main Dec 2, 2024
6 checks passed
@cquiroz cquiroz deleted the sc-4098-instrument-gmosnorth-not-part-of-call-for branch December 2, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants