-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to support adding collaborators. #324
Comments
I think the only difference in that case is that we could look up the collaborator's info and add that to the pending table. But they still need to affirmatively accept the invitation, don't you think? Seems like you wouldn't want to be added to someone's proposal without knowing it. So what I'm saying is, if you have to log in to click "accept" then you could just as easily log in and paste a code someone gave you, and it doesn't require you to have an ORCiD id beforehand. |
We currently don't require CoIs to confirm their participation. I remember a discussion about this with the NGOs long ago, so I'll have to try to dig up if there was a decision. Could we perhaps show the full list of CoIs and indicate which have confirmed and which have not? Could the confirmation be achieved by clicking a link in an email, like we see in 2FA emails? That's a good point that some CoIs might not have an ORCiD, so it would be advantageous if they could confirm participation without having to register. |
I chatted with Bryan about this and here are the highlights:
This notification email would give CoIs the opportunity to read the proposal, and if they decide that they don't want to participate they can email the PI to be removed. Or if they have edit privileges, they could even remove themselves? |
What do you mean by "read the proposal"? |
If PI Jill adds CoI Jack, then Explore sends an email to Jack with a link to the program. |
Yes, that's what I was getting at. We can try to hook it up via email (this is part of the user record if it's public in the ORCID record) but if the email address isn't in the ORCID profile or the CoI used a different email address to authenticate then we need to provide some kind of token for them to enter. If we send them a token but never ask for it (in the case where emails match) it seems like that would be kind of confusing. So I return to my original idea of just doing this with a token, which removes a lot of complexity and weird cases. |
Got it. That sounds reasonable. |
Ok @andrewwstephens this is the simplest collaborator workflow I can think of:
A slightly better workflow would email the token directly to the collaborator. We will need to figure out how to send emails, so this seems like a reasonable step 2, for XT.
Requiring collaborators to log in at least once seems like an ok constraint for XT. Non-user collaborators is a complication I'd like to avoid, or at least put off if we can.
What do you think?
The text was updated successfully, but these errors were encountered: