Fix check reply argument type

[HypenZou]

7days-golang/gee-rpc/day3-service/service.go

Line 75 in cf36443

if !isExportedOrBuiltinType(argType) || !isExportedOrBuiltinType(replyType) {

这里只检验了reply Argument是否为导出/内置类型, 没有检验其是否为指针
按照net/rpc的接口, 这是无法Register进入services的
是否应该加上检查是否为指针的操作?

[ray7jq]

TD

…

------------------ 原始邮件 ------------------ 发件人: "Dub ***@***.***>; 发送时间: 2022年2月17日(星期四) 晚上8:34 收件人: ***@***.***>; 抄送: ***@***.***>; 主题: [geektutu/7days-golang] Fix check reply argument type (PR #53) 7days-golang/gee-rpc/day3-service/service.go Line 75 in cf36443 if !isExportedOrBuiltinType(argType) || !isExportedOrBuiltinType(replyType) { 这里只检验了reply Argument是否为导出/内置类型, 没有检验其是否为指针 按照net/rpc的接口, 这是无法Register进入services的 是否应该加上检查是否为指针的操作? You can view, comment on, or merge this pull request online at:   #53 Commit Summary ffbd7c8 Update geerpc-day1.md 3d95165 fix: fix reply arg check File Changes (6 files) M gee-rpc/day3-service/service.go (7) M gee-rpc/day4-timeout/service.go (7) M gee-rpc/day5-http-debug/service.go (7) M gee-rpc/day6-load-balance/service.go (7) M gee-rpc/day7-registry/service.go (7) M gee-rpc/doc/geerpc-day1.md (2) Patch Links: https://github.com/geektutu/7days-golang/pull/53.patch https://github.com/geektutu/7days-golang/pull/53.diff — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>