Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header guard to lin.h file. #10

Open
ChrisPHL opened this issue Jan 3, 2021 · 3 comments
Open

Add header guard to lin.h file. #10

ChrisPHL opened this issue Jan 3, 2021 · 3 comments

Comments

@ChrisPHL
Copy link

ChrisPHL commented Jan 3, 2021

The code in lin.h file should be surrounded by header guard like this:

#ifndef LIN_H_
#define LIN_H_

// Code goes here.

#endif // LIN_H_

This way it can be included from several files at the same time without having problems of "redeclarations".

Have a nice day! :-)

Chris

@gandrewstone
Copy link
Owner

I've lost my LIN test setup. Can you make a PR with this and your prior report and if it works for you, I'll merge it. I hesitate to make any changes at all without at least a basic test, although this one ought to be completely innocuous....

@ChrisPHL
Copy link
Author

ChrisPHL commented Jan 4, 2021

I'll do! :-)
This one works for me perfectly of course.
I did test the diagnostic checksum utilizing a Saleae clone logic analyzer. It works for me perfectly, too.

@ChrisPHL
Copy link
Author

Btw: The Merge request is waiting... ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants