Implement REUSE.toml #863
Merged
Implement REUSE.toml #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenbianca
force-pushed
the
reuse-toml
branch
3 times, most recently
from
0dfe665
to
a792f1e
Compare
carmenbianca
force-pushed
the
reuse-toml
branch
5 times, most recently
from
c818ea4
to
03bfaf8
Compare
|
Some notes to self:
|
carmenbianca
commented
Nov 28, 2023
carmenbianca
force-pushed
the
reuse-toml
branch
2 times, most recently
from
33cdd16
to
5d49234
Compare
carmenbianca
commented
Dec 14, 2023
|
Notes to self:
|
|
What about renaming Thanks. |
|
Another note to self: see how this meshes with SPDX-FileContributor |
carmenbianca
force-pushed
the
reuse-toml
branch
from
ec280d6
to
2428dae
Compare
carmenbianca
commented
Jan 19, 2024
carmenbianca
force-pushed
the
reuse-toml
branch
2 times, most recently
from
5858061
to
39b56b9
Compare
carmenbianca
force-pushed
the
reuse-toml
branch
3 times, most recently
from
a746e74
to
dc6c248
Compare
|
Marking this ready for review. |
carmenbianca
force-pushed
the
reuse-toml
branch
from
a48f02f
to
9ba47be
Compare
This was annoying to maintain. Just getting all Python files in src/reuse is much easier. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
As detailed in a TODO comment, this makes it easier to share some common logic between .reuse/dep5 and REUSE.toml. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
REUSE.toml will implement the same abstract class. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
This is a fairly big commit that implements a lot of functionality surrounding REUSE.toml. It has feature parity with .reuse/dep5 at this stage, plus a somewhat primitive (but functioning) implementation of precedence. The error handling should be in order, but may need more work and/or testing. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
In 1.3.0, an issue was fixed where `poetry run` didn't return the correct exit code, which was problematic in some of our CI tests. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Also took the opportunity to rename GlobalPrecedence to PrecedenceType Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
This was wholly untested and would need a rewrite for REUSE.toml. It doesn't have a lot of use in the first place, so let's get rid of it for now. We can re-create it later. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
The solution was so simple!
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
|
I'm going to merge this. Rebasing this on top of main repeatedly is quite a bit of (useless) work. We can revert or adjust as needed after the merge, but I have high confidence in the quality of the PR. |
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Kladki
reviewed
May 26, 2024
Comment on lines
+13
to
+14
| SPDX-FileCopyrightText = "2017 Free Software Foundation Europe e.V. <https://fsfe.org>" | ||
| SPDX-License-Identifier = "GPL-3.0-or-later" |
There was a problem hiding this comment.
I am not that big of a fan of how verbose these keys are, and how they don't follow the style of the other keys. Maybe something like this would make more sense?
copyright_text = "2017 Free Software Foundation Europe e.V. <https://fsfe.org>"
license_identifier = "GPL-3.0-or-later"There was a problem hiding this comment.
Or should I move this concern/comment to https://github.com/fsfe/reuse-website?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779
See that issue for a more thorough explanation.