Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding --json to lint #654

Merged
merged 60 commits into from
Jun 1, 2023
Merged

Adding --json to lint #654

merged 60 commits into from
Jun 1, 2023

Commits on May 11, 2023

  1. Rework lint 

    Adding functions to retrieve and format the data from the `ProjectReport` class.
    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    cb94206 View commit details
    Browse the repository at this point in the history

  2. Add --json` argument

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    3ae8af7 View commit details
    Browse the repository at this point in the history

  3. Slim down data dictionary creation

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2e6805e View commit details
    Browse the repository at this point in the history

  4. Rework plaintext formatter

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    5a03e9e View commit details
    Browse the repository at this point in the history

  5. Move JSON formatter and re-add lint function

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    21d0026 View commit details
    Browse the repository at this point in the history

  6. Remove old output generation functions

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0b473f0 View commit details
    Browse the repository at this point in the history

  7. Adapt tests

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    74fd00e View commit details
    Browse the repository at this point in the history

  8. Add new tests

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    fb32ead View commit details
    Browse the repository at this point in the history

  9. Satisfy pylint

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    ff3d3c3 View commit details
    Browse the repository at this point in the history

  10. Satisfy isort

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    cfcac8e View commit details
    Browse the repository at this point in the history

  11. Make showing of license (not path) work on Windows

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    d749d51 View commit details
    Browse the repository at this point in the history

  12. Satisfy pylint (again)

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    5dcd872 View commit details
    Browse the repository at this point in the history

  13. Add changelog entry

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e03fb3e View commit details
    Browse the repository at this point in the history

  14. Fix typo

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    89dbd8b View commit details
    Browse the repository at this point in the history

  15. Move collect_data_from_report to ProjectReport.to_dict

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    034a9af View commit details
    Browse the repository at this point in the history

  16. (convenience) Add --format to easily switch between plain and JSON … 

    …output
    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6bb2a47 View commit details
    Browse the repository at this point in the history

  17. Get __REUSE_version__ from report object

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6bc172a View commit details
    Browse the repository at this point in the history

  18. Add newline at the end of the output

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2a2e44f View commit details
    Browse the repository at this point in the history

  19. Update tests according to code changes

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    5c25198 View commit details
    Browse the repository at this point in the history

  20. Fix minor issues in report.py

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f697c73 View commit details
    Browse the repository at this point in the history

  21. Fix plaintext output

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f20429f View commit details
    Browse the repository at this point in the history

  22. Add custom JSON serializer

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    1b2bd90 View commit details
    Browse the repository at this point in the history

  23. Adapt SpdxInfo namedtuple to contain source path

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    d98d162 View commit details
    Browse the repository at this point in the history

  24. Remove useless line

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    9c106f1 View commit details
    Browse the repository at this point in the history

  25. Actually return license/copyright source path

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    9beac70 View commit details
    Browse the repository at this point in the history

  26. Determine license source correctly

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c43c91f View commit details
    Browse the repository at this point in the history

  27. Allow returning empty arrays

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6fc5ec1 View commit details
    Browse the repository at this point in the history

  28. Satisfy black

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    3ad1fe3 View commit details
    Browse the repository at this point in the history

  29. Ensure consistency of the JSON output

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2fcc8eb View commit details
    Browse the repository at this point in the history

  30. Ensure consistency of the plaintext output

    @linozen @carmenbianca
    linozen authored and carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    d50d15e View commit details
    Browse the repository at this point in the history

  31. Move logic to FileReport.to_dict and rename method to to_dict_lint 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    fbf6e53 View commit details
    Browse the repository at this point in the history

  32. Create ProjectReport.is_compliant 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    bd59465 View commit details
    Browse the repository at this point in the history

  33. Rename json_version to lint_version 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8f3b5d0 View commit details
    Browse the repository at this point in the history

  34. Remove superfluous function 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8feed9e View commit details
    Browse the repository at this point in the history

  35. Make tests run by importing an existing function 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    7423f62 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Repair boolean check of SpdxInfo; object not iterable 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    f648356 View commit details
    Browse the repository at this point in the history

  2. Correctly use format_plain 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    c75a3e3 View commit details
    Browse the repository at this point in the history

  3. fixup! Rename json_version to lint_version

    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    5bc2c58 View commit details
    Browse the repository at this point in the history

  4. fixup! fixup! Rename json_version to lint_version

    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    54a8a66 View commit details
    Browse the repository at this point in the history

  5. Don't pass string where (optional) set is expected 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    d3208db View commit details
    Browse the repository at this point in the history

  6. fixup! Don't pass string where (optional) set is expected

    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    8a40fb6 View commit details
    Browse the repository at this point in the history

  7. fixup! fixup! Don't pass string where (optional) set is expected

    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    a769306 View commit details
    Browse the repository at this point in the history

  8. Create SpdxInfo.contains_copyright_or_licensing 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    cc5a383 View commit details
    Browse the repository at this point in the history

  9. Make lint version a global constant 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    23fa4cc View commit details
    Browse the repository at this point in the history

  10. Add tool version to json output 

    Signed-off-by: Carmen Bianca BAKKER <[email protected]>
    @carmenbianca
    carmenbianca committed May 21, 2023
    Configuration menu
    Copy the full SHA
    8fa808a View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Refactoring precedence for license path

    @linozen
    linozen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    c94b5a0 View commit details
    Browse the repository at this point in the history

  2. Add two --json specific test to tests/test_lint.py

    @linozen
    linozen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    7493ed1 View commit details
    Browse the repository at this point in the history

  3. Adapting two tests to new precedence behaviour

    @linozen
    linozen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    bb3217a View commit details
    Browse the repository at this point in the history

  4. Adding a warning when information is overriden

    @linozen
    linozen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    f2f1ef0 View commit details
    Browse the repository at this point in the history

  5. Import Path instead of PosixPath

    @linozen
    linozen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    cd820e1 View commit details
    Browse the repository at this point in the history

  6. Use StringIO object instead of normal string object

    @linozen
    linozen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    6c51545 View commit details
    Browse the repository at this point in the history

  7. Make sure that some keys are on top of sorted output

    @linozen
    linozen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    d1c2146 View commit details
    Browse the repository at this point in the history

  8. Make summary_contents a dictionary

    @linozen
    linozen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    c8baa6e View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Simplify lint --quiet

    @linozen
    linozen committed May 26, 2023
    Configuration menu
    Copy the full SHA
    983b0c4 View commit details
    Browse the repository at this point in the history

  2. Move dictionary sorting and test it

    @linozen
    linozen committed May 26, 2023
    Configuration menu
    Copy the full SHA
    d7af2e2 View commit details
    Browse the repository at this point in the history

  3. Rename SpdxInfo to ReuseInfo

    @linozen
    linozen committed May 26, 2023
    Configuration menu
    Copy the full SHA
    33456cb View commit details
    Browse the repository at this point in the history

  4. Rename ReuseInfo.license_path to ReuseInfo.source_path

    @linozen
    linozen committed May 26, 2023
    Configuration menu
    Copy the full SHA
    962521f View commit details
    Browse the repository at this point in the history

  5. Also encode source_type in ReuseInfo

    @linozen
    linozen committed May 26, 2023
    Configuration menu
    Copy the full SHA
    852b3fb View commit details
    Browse the repository at this point in the history

  6. Rename spdx_info_of to reuse_info_of

    @linozen
    linozen committed May 26, 2023
    Configuration menu
    Copy the full SHA
    322dd8a View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Add SourceType enum and use it for source_type in ReuseInfo 

    This commit adds a new enum `SourceType` with three possible values to indicate if the source type is a `.license file`, `file header` or `DEP5 file`. It then updates the usage of `source_type` by replacing the string type with the new `SourceType` enum type. This improves readability and makes the code more maintainable.
    @linozen
    linozen committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    7346234 View commit details
    Browse the repository at this point in the history