Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove potentially superfluous attributes in _File class #753

Closed
linozen opened this issue May 31, 2023 · 0 comments · Fixed by #787
Closed

Remove potentially superfluous attributes in _File class #753

linozen opened this issue May 31, 2023 · 0 comments · Fixed by #787

Comments

@linozen
Copy link
Member

linozen commented May 31, 2023

Since we should have a dataclass containing all the copyright and licensing information when #654 is merged, one might be able to remove the following attributes of the _File class:

class _File:
    """Represent an SPDX file. Sufficiently enough for our purposes, in any
    case.
    """
    def __init__(self, name, spdx_id=None, chk_sum=None):
        ...
        self.license_concluded: str = None
        self.copyright: str = None
        ...

It is likely that this is a larger refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant