Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS #17

Open
ldrrp opened this issue Dec 24, 2013 · 2 comments
Open

HTTPS #17

ldrrp opened this issue Dec 24, 2013 · 2 comments

Comments

@ldrrp
Copy link

ldrrp commented Dec 24, 2013

detect if using https and use it instead of http://www.google.com

@ldrrp
Copy link
Author

ldrrp commented Dec 24, 2013

Not having https support makes the map not load up since browsers will block anything on a page that does not use https on a https enabled page.

@judgej
Copy link

judgej commented May 1, 2014

Had this problem with a WP theme that happened to use this package. It took ages to trace it down.

There are three URLs in the library that have a hard-coded http: in, for example:

http://www.google.com/mapfiles/marker.png

This caused the page to fail the SSL certificate, making the site look insecure. The fix was simple: remove the http:

//www.google.com/mapfiles/marker.png

There is no need to "detect" whether SSL is in operation for the connection - just give the browser a schema-less URL and the browser will work that out for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants