Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel should center its text by default #176

Open
huyenltnguyen opened this issue Jun 6, 2024 · 1 comment
Open

Panel should center its text by default #176

huyenltnguyen opened this issue Jun 6, 2024 · 1 comment
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.

Comments

@huyenltnguyen
Copy link
Member

Description

At the moment, the Panel component doesn't have any text alignment rule set. Though, I'm seeing a lot of Panel usages with className="text-center" in /learn.

I think either:

  • Panel should have an alignment prop with center as the default; or
  • Panel.Heading and Panel.Body should have an alignment prop with center as the default (this is similar to the Modal component)
@huyenltnguyen huyenltnguyen added the status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. label Jun 6, 2024
@ZEviod
Copy link

ZEviod commented Sep 19, 2024

Hey @huyenltnguyen ,

I'm interested in fixing this.
Should I proceed with this? Are there any specific requirements or considerations I need to be aware of before starting?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.
Projects
None yet
Development

No branches or pull requests

2 participants