Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/r17 #38

Open
wants to merge 41 commits into
base: next
Choose a base branch
from
Open

feat/r17 #38

wants to merge 41 commits into from

Conversation

a3828162
Copy link
Contributor

No description provided.

internal/sbi/consumer/nf_management_test.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nf_discovery.go Outdated Show resolved Hide resolved
Copy link

@yccodr yccodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some problems found. Please fix it 😓

Some Tips:

  • Regex of replacing all the http method string to library-provided constant string:
    • strings.ToUpper("Get") -> http.MethodGet: `:%s/strings.ToUpper("(.*)")/http.Method$1/g

internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/api_parameterprovision.go Outdated Show resolved Hide resolved
internal/sbi/api_subscriberdatamanagement.go Outdated Show resolved Hide resolved
internal/sbi/api_ueauthentication.go Outdated Show resolved Hide resolved
internal/sbi/api_uecontextmanagement.go Outdated Show resolved Hide resolved
internal/sbi/api_ueid.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Show resolved Hide resolved
Copy link

@yccodr yccodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some problems found. Please fix it 😓

Some Tips:

  • Regex of replacing all the http method string to library-provided constant string:
    • strings.ToUpper("Get") -> http.MethodGet: :%s/strings.ToUpper\("(.*)"\)/http.Method$1/g

@a3828162
Copy link
Contributor Author

Some problems found. Please fix it 😓

Some Tips:

  • Regex of replacing all the http method string to library-provided constant string:

    • strings.ToUpper("Get") -> http.MethodGet: :%s/strings.ToUpper\("(.*)"\)/http.Method$1/g

Thanks for your comment, I fix it.

internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
pkg/factory/config.go Outdated Show resolved Hide resolved
@ianchen0119 ianchen0119 changed the base branch from main to next November 12, 2024 06:39
Copy link
Contributor

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiError, ok := err.(openapi.GenericOpenAPIError)

The apiError will be nil if the ok is false

pkg/service/init.go Outdated Show resolved Hide resolved
internal/sbi/processor/ue_context_management.go Outdated Show resolved Hide resolved
internal/sbi/processor/ue_context_management.go Outdated Show resolved Hide resolved
internal/sbi/processor/ue_context_management.go Outdated Show resolved Hide resolved
internal/sbi/processor/ue_context_management.go Outdated Show resolved Hide resolved
internal/sbi/processor/ue_context_management.go Outdated Show resolved Hide resolved
internal/sbi/processor/ue_context_management.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants