-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/r17 #38
base: next
Are you sure you want to change the base?
feat/r17 #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some problems found. Please fix it 😓
Some Tips:
- Regex of replacing all the http method string to library-provided constant string:
strings.ToUpper("Get") -> http.MethodGet
: `:%s/strings.ToUpper("(.*)")/http.Method$1/g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some problems found. Please fix it 😓
Some Tips:
- Regex of replacing all the http method string to library-provided constant string:
strings.ToUpper("Get") -> http.MethodGet
::%s/strings.ToUpper\("(.*)"\)/http.Method$1/g
Thanks for your comment, I fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apiError, ok := err.(openapi.GenericOpenAPIError)
The apiError
will be nil if the ok
is false
No description provided.