Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate code formatting, tool installation in make #27

Open
juliaogris opened this issue Sep 28, 2020 · 1 comment
Open

Automate code formatting, tool installation in make #27

juliaogris opened this issue Sep 28, 2020 · 1 comment

Comments

@juliaogris
Copy link
Member

We should probably have a make target for formatting go code (currently the contributors have their editors set up accordingly). Along with it we should have make targets checking that the code is formatted, e.g.:

 make fmt
 make check-fmt

According to a PR conversation, we might want to use an extension to gofumports for code formatting. We might want to consider moving this extension into a separate script files directory, maybe even repository.

We might also want to consider adding:

 make get-tools

To download gofumports and|or scripts.

@juliaogris juliaogris changed the title make: code formatting, tool installation Automate code formatting, tool installation in make Sep 28, 2020
@juliaogris
Copy link
Member Author

We might also want to work out linter version derivation in a separate script:
https://github.com/foxygoat/jsonnext/pull/25/files#r495622807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant