Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLatform Check cause fatals #58

Open
generalredneck opened this issue Jul 11, 2024 · 0 comments
Open

PLatform Check cause fatals #58

generalredneck opened this issue Jul 11, 2024 · 0 comments

Comments

@generalredneck
Copy link
Member

generalredneck commented Jul 11, 2024

It's usually best practice to release code that works on both the old and new version of PHP that we are upgrading to. That said, since Composer 2, platform_check.php has always been generated. While this is good to have on locals AND CI, we don't want it to bring down production while we do an upgrade on hosts like acquia/siteground etc. Furthermore, the CLI PHP version may be different than the Website PHP version. WHile this may cause soem libraries to not work 100%, most times, the majority of actions will. We want that more graceful failure than the heavy handed platform check. Consider looking at https://php.watch/articles/composer-platform-check and adding composer-min-autoload to php-build script building out the artifact, or at least running composer config platform-check false during artifact build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant