Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: --gas-report groups all methods of all contracts that use the same type of proxy contract #9115

Open
2 tasks done
sakulstra opened this issue Oct 14, 2024 · 0 comments
Open
2 tasks done
Labels
A-gas-snapshots Area: gas snapshotting/reporting C-forge Command: forge Cmd-forge-test Command: forge test T-bug Type: bug

Comments

@sakulstra
Copy link
Contributor

sakulstra commented Oct 14, 2024

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

No response

Operating System

macOS (Apple Silicon)

Describe the bug

After trying to generate --json output where i faced #9111 I played a bit around and faced another "bug"? in regards to the output in general.

If you have multiple contracts in a repo using the same type of proxy (e.g. oz TransparentUpgradeableProxy), foundy will group all methods of all contracts using this proxy together. What is even worse, i think when multiple implementations implement the same signature (e.g. transfer - it will show as one and consider all implementations for things like average etc).


Not 100% sure what the solution is, perhaps it could be possible to differentiate multiple Proxies dependent on the impl being delegate-called?

@sakulstra sakulstra added T-bug Type: bug T-needs-triage Type: this issue needs to be labelled labels Oct 14, 2024
@sakulstra sakulstra changed the title Gas report proxy management --gas-report proxy management Oct 14, 2024
@zerosnacks zerosnacks self-assigned this Oct 15, 2024
@zerosnacks zerosnacks added the A-gas-snapshots Area: gas snapshotting/reporting label Oct 15, 2024
@zerosnacks zerosnacks changed the title --gas-report proxy management bug: --gas-report groups all methods of all contracts that use the same type of proxy contract Oct 15, 2024
@zerosnacks zerosnacks removed their assignment Oct 15, 2024
@zerosnacks zerosnacks added Cmd-forge-test Command: forge test C-forge Command: forge and removed T-needs-triage Type: this issue needs to be labelled labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-gas-snapshots Area: gas snapshotting/reporting C-forge Command: forge Cmd-forge-test Command: forge test T-bug Type: bug
Projects
Status: Todo
Development

No branches or pull requests

2 participants