Adding space in between the skill bubble on the skill page in mobile view #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohitm15
approved these changes
May 23, 2020
akshatnitd
requested changes
May 24, 2020
|
@akshatnitd , i've made the changes in desktop view too. Changed the width from 55% to 100%. |
anishagg17
reviewed
May 28, 2020
| @@ -359,7 +359,7 @@ class SkillListing extends Component { | |||
| key={index} | |||
| data={data} | |||
| history={history} | |||
| margin={'1.5% 2.85% 1.5% 0'} | |||
| margin={'12px 10px 12px 0'} | |||
There was a problem hiding this comment.
Why pixles insted of percentage ?
There was a problem hiding this comment.
Percentage is a relative unit. So, the margin will change according to the screen of size.On a really small screen like a phone that might be appropriate. But if you're viewing that same page on a bigger size screen, that margin is going to be huge if we use percentage. That's why I've used pixels to maintain the same gap between them.
|
@akshatnitd , please suggest if there are some more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3552
Changes: Added space in between the skill bubbles and width of the skill bubble section changed to 100%.
Demo Link: https://pr-3552-fossasia-susi-web-chat.surge.sh
Screenshots:
Before
After
