Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we enable Django Admin? #121

Open
hongquan opened this issue Jun 18, 2024 · 0 comments
Open

Should we enable Django Admin? #121

hongquan opened this issue Jun 18, 2024 · 0 comments

Comments

@hongquan
Copy link
Member

hongquan commented Jun 18, 2024

One of Django best-selling point is its builtin Admin site feature. But don't know why venueless doesn't use it and instead implement its own "Control" area (/control/), which is not feature-complete and has weird UX:

image

  • The validation error message doesn't point out which field failed.
  • The Id field in the screenshot saves to primary key. If it is primary key, it should not be exposed to user to give value. Its value should be automatically generated.
  • The timezone field should be a dropdown, because not every one can remember and type correctly.
  • Each field should have help text to explain what the field is for and how the value should be.

I think we should enable Django Admin for data management. An alternative page like "Control" should be for some kind of "middle-level" users (has management right but not superuser) like organization member (in case eventyay-video serves like a SaaS).

Another idea, putting here in case I forget later: Currently, for User model, eventyay-video is using Django's builtin model (django.contrib.auth.models.User), but from my experience and also from Django advice, we should define a custom User model, even if it is just a copy of Django one. It is because, day by day, we will have new needs for User model that the Django built-in one no longer meets, but changing then is too late. Switching User model for running services is very difficult. If we use a custom User model from the beginning, it is easy to modify it to adapt to new needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant