Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"External Diff" shortcut on added/removed files? #2358

Open
ocornut opened this issue Nov 1, 2024 · 3 comments
Open

"External Diff" shortcut on added/removed files? #2358

ocornut opened this issue Nov 1, 2024 · 3 comments
Milestone

Comments

@ocornut
Copy link

ocornut commented Nov 1, 2024

When browsing a commit or branch I frequently use CTRL+D shortcut to open the diff tools to compare change in one file.

It doesn't work however if a file was added or removed:

image

Or course the removed or new file can be seen into Fork's own preview panes, but I like my diff tool, and it feels like the reviewing workflow would be more consistent if when pressing CTRL+D in this situation it would open my external diff tool with a temporary empty file on the other side.

Thank you for considering this small change :)

@ocornut ocornut changed the title External Diff shortcut on added/removed files? "External Diff" shortcut on added/removed files? Nov 1, 2024
@DanPristupov DanPristupov added this to the 2.2 milestone Nov 5, 2024
@DanPristupov
Copy link
Contributor

Hi 👋. I made a test build. Can you try the improvement works as you expected?

https://cdn.fork.dev/prerelease/ForkWin-2.2.10.zip

Just extract .zip somewhere and run fork.exe.

@ocornut
Copy link
Author

ocornut commented Nov 6, 2024

Thanks for the update. Unfortunately I did it, it updated my git instance and now Fork (old version or this) doesn't find a proper working git instance... my AppData\Local\Fork\gitInstance\ folder is empty. Trying to resolve now :)

@ocornut
Copy link
Author

ocornut commented Nov 6, 2024

FYI I tried to reinstall last version from the website, it fixed it but I lost all my Fork settings.
I then re-ran your version linked above, and External Diff worked as a expected. Thank you!

Losing my settings is a bit annoying but not the end of the world. It's however the first time it happens for me with Fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants